On 9/18/2023 1:31 PM, Ferruh Yigit wrote:
> On 9/15/2023 10:15 AM, Chaoyong He wrote:
>> Move the definition of data structure into the implement file.
>> Also sync the logic from kernel driver and remove the unneeded header
>> file include statements.
>>
>> Signed-off-by: Chaoyong He <chaoyong...@corigine.com>
>> Reviewed-by: Niklas Söderlund <niklas.soderl...@corigine.com>
>
> <...>
>
>> @@ -381,6 +478,43 @@ nfp_nsp_command_buf(struct nfp_nsp *nsp,
>> return ret;
>> }
>>
>> +#define SZ_1M 0x00100000
>> +#define SZ_4K 0x00001000
>> +
>> +static int
>> +nfp_nsp_command_buf(struct nfp_nsp *nsp,
>> + struct nfp_nsp_command_buf_arg *arg)
>> +{
>> + int err;
>> + uint64_t reg;
>> + uint32_t size;
>> + uint32_t max_size;
>>
>
> One of the previous patches, patch 3/27, updates variable type
> 'unsigned int max_size;' -> 'size_t max_size;'
>
> Now it is updated again to 'uint32_t max_size;', I assume by mistake
> that previous patch updated by this one didn't.
>
> If it is by mistake can you please check all patches that moves code, if
> they are aligned with previous cleanups.
> Or if this is intentional, can you please update the first patch to set
> the variable correct at first place?
>
This comment is for v4, I replied to wrong version.
