On 9/15/2023 10:15 AM, Chaoyong He wrote: > This patch series aims to: > - Make the coding style satisfy with DPDK. > - Sync the logic with kernel driver. > - Make the sub-module more modular. > - Extend the nfp configure BAR from 8 to 24. > > --- > v3: > * Fix one bug in the BAR find logic. > * Modify more coding style. > v2: > * Fix the compile error in Fodora 37 environment. > --- > > Chaoyong He (27): > net/nfp: explicitly compare to null and 0 > net/nfp: unify the indent coding style > net/nfp: unify the type of integer variable > net/nfp: remove the unneeded logic > net/nfp: standard the local variable coding style > net/nfp: adjust the log statement > net/nfp: standard the comment style > net/nfp: using the DPDK memory management API > net/nfp: standard the blank character > net/nfp: unify the guide line of header file > net/nfp: rename some parameter and variable > net/nfp: refact the hwinfo module > net/nfp: refact the nffw module > net/nfp: refact the mip module > net/nfp: refact the rtsym module > net/nfp: refact the resource module > net/nfp: refact the target module > net/nfp: add a new header file > net/nfp: refact the nsp module > net/nfp: refact the mutex module > net/nfp: rename data field to sync with kernel driver > net/nfp: add the dev module > net/nfp: add header file for PCIe module > net/nfp: refact the cppcore module > net/nfp: refact the PCIe module > net/nfp: refact the cppcore and PCIe module > net/nfp: extend the usage of nfp BAR from 8 to 24 >
Hi Chaoyong, Niklas, I put some comments on patches, mostly minor comments, only critical one is the decision to use rte memory management widely or not, please check comments.
