On Wed, Sep 06, 2023 at 06:12:27PM +0200, Thomas Monjalon wrote:
> The deprecated functions rte_thread_setname() and rte_ctrl_thread_create()
> are replaced with the new rte_thread API:
>
> rte_thread_setname()
> can be replaced with
> rte_thread_set_name()
> or rte_thread_set_prefixed_name()
>
> rte_ctrl_thread_create()
> can be replaced with
> rte_thread_create_control()
> or rte_thread_create_internal_control()
>
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> ---
Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
with suggestions.
...
> ABI Changes
> diff --git a/lib/eal/common/eal_common_thread.c
> b/lib/eal/common/eal_common_thread.c
> index 31c37e3102..78f643af73 100644
> --- a/lib/eal/common/eal_common_thread.c
> +++ b/lib/eal/common/eal_common_thread.c
> @@ -248,7 +248,7 @@ struct rte_thread_ctrl_params {
> enum __rte_ctrl_thread_status ctrl_thread_status;
> };
the code above here
struct rte_thread_ctrl_params i think can now get renamed to
rte_thread_control_params and i think we can get rid of the union.
if i look through the code history i only added it to help maintain
compatibility while we had both ctrl and control thread APIs.
>
> -static int ctrl_thread_init(void *arg)
> +static int control_thread_init(void *arg)
> {
> struct internal_config *internal_conf =
> eal_get_internal_configuration();
> @@ -273,80 +273,18 @@ static int ctrl_thread_init(void *arg)
> return 0;
> }
