> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Monday, August 21, 2023 7:36 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; ferruh.yi...@amd.com; Xia, Chenbo
> <chenbo....@intel.com>; nipun.gu...@amd.com; Richardson, Bruce
> <bruce.richard...@intel.com>
> Subject: [PATCH v2 15/15] devtools: forbid inclusion of Linux header for
> PCI
>
> Refrain from including Linux-only pci_regs.h header.
> Instead, prefer our own definitions from the pci library.
>
> Signed-off-by: David Marchand <david.march...@redhat.com>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
> devtools/checkpatches.sh | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 43f5e36a18..5d3c5aaba5 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -127,6 +127,14 @@ check_forbidden_additions() { # <patch>
> -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
> "$1" || res=1
>
> + # forbid inclusion of Linux header for PCI constants
> + awk -v FOLDERS="lib drivers app examples" \
> + -v EXPRESSIONS='include.*linux/pci_regs\\.h' \
> + -v RET_ON_FAIL=1 \
> + -v MESSAGE='Using linux/pci_regs.h, prefer rte_pci.h' \
> + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
> + "$1" || res=1
> +
> # forbid use of experimental build flag except in examples
> awk -v FOLDERS='lib drivers app' \
> -v EXPRESSIONS='-DALLOW_EXPERIMENTAL_API
> allow_experimental_apis' \
> --
> 2.41.0
Reviewed-by: Chenbo Xia <chenbo....@intel.com>
