On 9/1/2023 3:30 AM, Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. >
Hi Wenbo, After this patch, driver doesn't implement any of the dev_ops (struct eth_dev_ops), so I assume it is not functional at all. But meanwhile patchset has devargs parsing, fw_update, LSC interrupts, implemented etc. I think it makes testing/reviewing harder to add more code before basic device functionality is missing. What about implementing following main dev_ops and implement a simple datapath, to have minimum working driver, later add features on top of it: dev_configure dev_start dev_stop dev_close dev_infos_get rx_queue_setup tx_queue_setup Also I have comment on putting 'mac_ops' on process_private, I suspect there is a design problem there, please check details in relevant patch. Thanks, Ferruh > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx-cksum-offload,rss,vlan-filter > flow_clow,uncast_filter,mcast_filter,1588,Jumbo-frame > The Feature tx side can supprt tx-cksum-offload,tso,vxlan-tso > flow director base on ntuple pattern of tcp/udp/ip/ eth_hdr->type > for sriov is also support. > > Because of the chip desgin defect, for multiple-port mode > one pci-bdf will have multiple-port (max can have four ports) > so this code must be care of one bdf init multiple-port. > > v6: > * fixed the doc(rst) format problem advise by Thomas Monjalon > > v5: > * fixed the symbol name require by the style documentation > rx_queue_setup > v4: > * one patch has been forgot to upload :( > > v3: > * fixed http://dpdk.org/patch/129830 FreeBSD 13 compile Issue > * change iobar type to void suggest by Stephen Hemminger > * add KMOD_DEP support for vfio-pci > * change run-cmd argument parse check for invalid extra_args > > v2: > * fixed MAINTAIN maillist fullname format > * fixed driver/net/meson the order issue of new driver to driver list > * improve virtual point function usage suggest by Stephen Hemminger > > > Wenbo Cao (8): > net/rnp: add skeleton > net/rnp: add ethdev probe and remove > net/rnp: add device init and uninit > net/rnp: add mbx basic api feature > net/rnp add reset code for Chip Init process > net/rnp add port info resource init > net/rnp add devargs runtime parsing functions > net/rnp handle device interrupts > >
