On Thu, Aug 31, 2023 at 05:47:35PM +0100, Harry van Haaren wrote: > This commit adds a unit test for an issue identified > where ordered history-list entries are not correctly > cleared when the returned event is of op RELEASE type. > > The result of the history-list bug is that a future event > which re-uses that history-list slot, but has an op type > of FORWARD will incorrectly be reordered. > > The existing unit-tests did not cover the RELEASE of an > ORDERED queue, and then stress-test the history-list by > iterating HIST_LIST times afterwards. > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > --- Hi Harry,
having the test first is good for showing up the bug, but won't that mean that our unit tests are broken until after the second patch is applied? If so, I suggest reversing the order of the series so the tests always return clean. [If no V2 necessary, the order can maybe be switched on apply] /Bruce