Hello Tyler, On Thu, Aug 24, 2023 at 10:30 AM David Marchand <david.march...@redhat.com> wrote: > diff --git a/lib/eal/include/rte_debug.h b/lib/eal/include/rte_debug.h > index 2c4b94a7c9..74593cd4d4 100644 > --- a/lib/eal/include/rte_debug.h > +++ b/lib/eal/include/rte_debug.h > @@ -60,11 +60,7 @@ void rte_dump_stack(void); > * documentation. > */ > void __rte_panic(const char *funcname , const char *format, ...) > -#ifdef __GNUC__ > -#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 2)) > __rte_cold > -#endif > -#endif
I don't see some wrapping around __rte_cold for MSVC in your series. Would this patch break MSVC buidlds? > __rte_noreturn > __rte_format_printf(2, 3); > -- David Marchand