On Fri, Aug 25, 2023 at 6:14 PM Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > On Thu, Aug 24, 2023 at 10:52:04AM +0200, David Marchand wrote: > > Hello Tyler, > > > > On Thu, Aug 24, 2023 at 10:30 AM David Marchand > > <david.march...@redhat.com> wrote: > > > diff --git a/lib/eal/include/rte_debug.h b/lib/eal/include/rte_debug.h > > > index 2c4b94a7c9..74593cd4d4 100644 > > > --- a/lib/eal/include/rte_debug.h > > > +++ b/lib/eal/include/rte_debug.h > > > @@ -60,11 +60,7 @@ void rte_dump_stack(void); > > > * documentation. > > > */ > > > void __rte_panic(const char *funcname , const char *format, ...) > > > -#ifdef __GNUC__ > > > -#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 2)) > > > __rte_cold > > > -#endif > > > -#endif > > > > I don't see some wrapping around __rte_cold for MSVC in your series. > > Would this patch break MSVC buidlds? > > If it gets expanded on MSVC probably. But don't let it stop you from > applying this series. You can just expand it empty if you want.
That's what I did for safety when I applied the msvc series. > > Until the atomics series is merged msvc still won't build so I'll supply > minor fixes as these things pop up. > > Once everything is staged I'll work with UNH to get a basic build CI > going to reduce the overhead of worrying about this kind of change being > breaking. Yes, the sooner, the better. -- David Marchand
