> -----Original Message-----
> From: Aakash Sasidharan <asasidha...@marvell.com>
> Sent: Tuesday, August 22, 2023 6:47 PM
> To: Gujjar, Abhinandan S <abhinandan.guj...@intel.com>; Akhil Goyal
> <gak...@marvell.com>
> Cc: jer...@marvell.com; sthot...@marvell.com; ano...@marvell.com;
> dev@dpdk.org; asasidha...@marvell.com
> Subject: [PATCH 3/3] test/event_crypto_adapter: fix crypto null dev creation
> 
> Create crypto null device only if no other crypto devices were found.
> 
> Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test")
> Cc: abhinandan.guj...@intel.com
> 
> Signed-off-by: Aakash Sasidharan <asasidha...@marvell.com>
> ---
>  app/test/test_event_crypto_adapter.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 00b20fa443..0c56744ba0 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -1072,11 +1072,10 @@ configure_cryptodev(void)
>               return TEST_FAILED;
>       }
> 
> -     /* Create a NULL crypto device */
> -     nb_devs = rte_cryptodev_device_count_by_driver(
> -                     rte_cryptodev_driver_id_get(
> -                     RTE_STR(CRYPTODEV_NAME_NULL_PMD)));
> +
> +     nb_devs = rte_cryptodev_count();
The test is intended to do on NULL cipher with NULL PMD. 
Right now, the test does cipher with " RTE_CRYPTO_CIPHER_NULL".
With this changes, does this test work, if you provide any other cryptodev like 
AESNI, QAT, OpenSSL other than NULL PMD?
>       if (!nb_devs) {
> +             /* Create a NULL crypto device */
>               ret = rte_vdev_init(
>                       RTE_STR(CRYPTODEV_NAME_NULL_PMD), NULL);
> 
> --
> 2.25.1

Reply via email to