On Wed, Aug 09, 2023 at 02:24:09PM +0200, David Marchand wrote:
> Sorry, two additional comments after running more checks.
>
> lib/log files are not referenced in MAINTAINERS, can you add a new block?
>
Yep.
> > diff --git a/lib/log/meson.build b/lib/log/meson.build
> > new file mode 100644
> > index 0000000000..6baff83ee5
> > --- /dev/null
> > +++ b/lib/log/meson.build
> > @@ -0,0 +1,9 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2022 Intel Corporation
> > +
> > +includes += global_inc
> > +sources = files(
> > + 'log.c',
> > + 'log_' + exec_env + '.c'
> > +)
>
> Missing a , (reported by check-meson.py).
>
> > +headers = files('rte_log.h')
>
Will review all feedback and spin a new revision.
thanks,
/Bruce
