On Mon, Jul 31, 2023 at 05:29:04PM +0100, Bruce Richardson wrote: > On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote: > > On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson > > <bruce.richard...@intel.com> wrote: > > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > > > index 1a4210b948..40f7dd2877 100644 > > > --- a/doc/api/doxy-api.conf.in > > > +++ b/doc/api/doxy-api.conf.in > > > @@ -52,6 +52,7 @@ INPUT = > > > @TOPDIR@/doc/api/doxy-api-index.md \ > > > @TOPDIR@/lib/kni \ > > > @TOPDIR@/lib/kvargs \ > > > @TOPDIR@/lib/latencystats \ > > > + @TOPDIR@/lib/log \ > > > @TOPDIR@/lib/lpm \ > > > @TOPDIR@/lib/mbuf \ > > > @TOPDIR@/lib/member \ > > > > In case you are wondering about the reason.. the Intel CI reports an > > error on building the documentation: > > > > *Build Failed #1: > > OS: UB2204-64 > > Target: x86_64-native-linuxapp-doc > > FAILED: doc/api/html > > /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html > > /usr/bin/doxygen doc/api/doxy-api.conf > > /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc/api/doxy-api-index.md:230: > > error: unable to resolve reference to 'rte_log.h' for \ref command > > (warning treated as error, aborting now) > > Traceback (most recent call last): > > File > > "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py", > > line 13, in <module> > > subprocess.run(doxygen_command, check=True, stdout=out) > > File "/usr/lib/python3.10/subprocess.py", line 524, in run > > raise CalledProcessError(retcode, process.args, > > subprocess.CalledProcessError: Command '['/usr/bin/doxygen', > > 'doc/api/doxy-api.conf']' returned non-zero exit status 1. > > [2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o > > [2773/2774] Generating doc/guides/html_guides with a custom command > > ninja: build stopped > > > > IIRC Intel CI excludes changes on the doc/ directory when applying patches. > > http://inbox.dpdk.org/dev/cy5pr11mb618735108d3e9d90c67eef96f5...@cy5pr11mb6187.namprd11.prod.outlook.com/ > > > > .. which seems to match the failure reported here, as doxygen would > > fail to find rte_log.h. > > > Yes, I was very much wondering about the reason for failure, since I could > find no issues with building the docs on my own system! > Is this patchset ok for merge then, or is there something else outstanding holding it back?
Thanks, /Bruce
