On Mon, Jul 03, 2023 at 02:14:06PM +0200, Thomas Monjalon wrote:
> When looking at threads in a system, it can be confusing
> to find some unknown threads without a clue it is started by DPDK.
> 
> Let's start all thread names with "dpdk-"
> plus the driver name if it comes from a driver.
> 
> One more constraint: the thread names are generally limited
> to 16 characters, including the NUL character.
> 
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> ---
> Please review carefully, I may have missed things.

i think the only caution here is that some of the new names may be
truncated where the valuable information is lost in the truncation?

#define RTE_MAX_THREAD_NAME_LEN 16

a limit inherited from linux and adopted as the dpdk standard/maximum.
by prefixing dpdk- we end up with a bit less name length budget to spend
potentially causing the most important part of the thread name to be lost.

a couple of notes though.
  * some of the existing names may already suffer from truncation. i
    didn't check but can see some that look close.
  * some of your new names have reduced the length so they are in fact
    better.

Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>

Reply via email to