On Wed, 2023-07-05 at 19:57 -0700, Stephen Hemminger wrote:
> On Tue, 29 Nov 2022 14:04:45 -0800
> Tyler Retzlaff <roret...@linux.microsoft.com> wrote:
> 
> > > Markus and I ultimately use the function in the patch to call
> > > rte_thread_setname() (which takes the pthread id as an argument) to
> > > rename our
> > > lcore workers from "lcore-worker-X" to something more meaningful in the
> > > scope
> > > of our application. Having descriptive thread names makes debugging
> > > significantly easier. For example, verifying CPU pinning worked as
> > > intended
> > > with ps -T ..., or identifying threads in the Intel VTune profiler.
> 
> Why not have the worker threads rename themselves?

That's the way we ended up with, i.e. something like        
rte_thread_setname(pthread_self(), "...");
called by each worker.

I guess due to the possibility to set the name by pthread id, and obtain it for
ctrl threads, but not for regular workers, we got the impression of a "missing
piece" in the API. I understand the motivation to keep pthread internals out of
the API, so i guess we can drop the patch.

Thanks
Michael

-- 
Michael Pfeiffer

Technische Universität Ilmenau
Fakultät für Informatik und Automatisierung
Fachgebiet Telematik / Rechnernetze

E-Mail: michael.pfeif...@tu-ilmenau.de
Telefon: +49 3677 69-4854
Web: https://www.tu-ilmenau.de/telematik

Reply via email to