On Thu, Jun 15, 2023 at 9:08 AM Fengnan Chang <changfeng...@bytedance.com> wrote: > > When there is not enough space to memsegs, we should prompt > which configuration should be modified instead of printing > some numbers. > > Signed-off-by: Fengnan Chang <changfeng...@bytedance.com>
This lgtm, but I have a question: $ git grep 'RTE_STR(RTE_MAX' app/test/test_eal_flags.c: "-l", RTE_STR(RTE_MAX_LCORE) }; app/test/test_eal_flags.c: "-l", "1-"RTE_STR(RTE_MAX_LCORE) }; lib/eal/common/eal_common_dynmem.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/common/eal_common_dynmem.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/freebsd/eal_memory.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/linux/eal_memory.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/linux/eal_memory.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); The first two hits are false positives, but the mentions of RTE_MAX_MEMSEG_LISTS are all in log messages. Could you have a look and confirm it is related to your change? -- David Marchand
