> -----Original Message----- > From: Junfeng Guo <[email protected]> > Sent: Wednesday, June 14, 2023 1:14 PM > To: Wu, Jingjing <[email protected]> > Cc: [email protected]; [email protected]; He, Xingguang > <[email protected]>; Laatz, Kevin <[email protected]>; Guo, > Junfeng <[email protected]> > Subject: [PATCH] examples/ntb: remove redundant logic for dev close > > During EAL cleanup stage, all bus devices are cleaned up properly. > Based on this, there is no need to do extra device close process, which may > call the dev ops '*dev->dev_ops->dev_close' twice. > > If this dev ops for ntb was called twice, the interrupt handle for EAL will be > disabled twice and will lead to error for the seconde time. Like this: "EAL: > Error disabling MSI-X interrupts for fd xx" > > Thus, this patch just remove the redundant logic for device close. > Ports will be closed at rte_eal_cleanup() in the main loop. > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > Cc: [email protected] > > Signed-off-by: Junfeng Guo <[email protected]> > ---
Tested-by: Wei Ling <[email protected]>
