When libnuma development package is missing on a system, DPDK can still be built but will be missing much-needed support for NUMA memory management. This may later cause issues at runtime if the resulting binary is run on a NUMA system.
We can reduce the incidence of such runtime errors by ensuring that, for native builds*, libnuma is present - unless the user actually specifies via "max_numa_nodes" that they don't require NUMA support. Having this as an error condition is also in keeping with what is documented in the Linux GSG doc, where libnuma is listed as a requirement for building DPDK [1]. * NOTE: cross-compilation builds have a different logic set, with a separate "numa" value indicating if numa support is necessary. [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> Signed-off-by: David Marchand <david.march...@redhat.com> --- V3: - install 32-bit libnuma packages on CI systems [thanks to David for the changes] - split the patch out of the previous patchset, so it can be tracked separately from the more minor fixup changes. V2: Limit check to linux only --- .github/workflows/build.yml | 5 ++++- config/meson.build | 9 +++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3b629fcdbd..a479783bbc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -91,6 +91,9 @@ jobs: with: path: reference key: ${{ steps.get_ref_keys.outputs.abi }} + - name: Configure i386 architecture + if: env.BUILD_32BIT == 'true' + run: sudo dpkg --add-architecture i386 - name: Update APT cache run: sudo apt update || true - name: Install packages @@ -104,7 +107,7 @@ jobs: pkg-config - name: Install i386 cross compiling packages if: env.BUILD_32BIT == 'true' - run: sudo apt install -y gcc-multilib g++-multilib + run: sudo apt install -y gcc-multilib g++-multilib libnuma-dev:i386 - name: Install aarch64 cross compiling packages if: env.AARCH64 == 'true' run: sudo apt install -y crossbuild-essential-arm64 diff --git a/config/meson.build b/config/meson.build index 22d7d908b7..d8223718e4 100644 --- a/config/meson.build +++ b/config/meson.build @@ -381,6 +381,15 @@ endif if not dpdk_conf.has('RTE_MAX_NUMA_NODES') error('Number of NUMA nodes not specified.') endif +if (is_linux and + dpdk_conf.get('RTE_MAX_NUMA_NODES') > 1 and + not meson.is_cross_build() and + not has_libnuma) + error(''' +No NUMA library (development package) found, yet DPDK configured for multiple NUMA nodes. +Please install libnuma, or set 'max_numa_nodes' option to '1' to build without NUMA support. +''') +endif # set the install path for the drivers dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path) -- 2.39.2
