On Tue, 16 Apr 2019 10:59:12 +0900 ogawa.yasuf...@lab.ntt.co.jp wrote: > From: Yasufumi Ogawa <ogawa.yasuf...@lab.ntt.co.jp> > > In secondary_msl_create_walk(), it creates a file for fbarrays with its > PID for reserving unique name among secondary processes. However, it > does not work as expected if secondary is run as app container becuase > each of containerized secondary has PID 1. To reserve unique name, use > hostname instead of PID if the value is 1. > > Cc: sta...@dpdk.org > > Signed-off-by: Yasufumi Ogawa <ogawa.yasuf...@lab.ntt.co.jp> > ---
Since this is an ABI break. I propose that a more invasive solution would be better. Either change to using something more unique GUID or change the fbarray structure to be a variable length array. The internals of fbarray should also be hidden (ie not in rte_fbarray.h) and the init() function changed into something that allocates the array. The current patch has not gotten any followup or acceptance in 4 years. So marking it as changes requested.
