> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Friday, June 9, 2023 10:37 PM > To: Jerin Jacob <jerinjac...@gmail.com> > Cc: Yan, Zhirun <zhirun....@intel.com>; Thomas Monjalon > <tho...@monjalon.net>; dev@dpdk.org; jer...@marvell.com; > kirankum...@marvell.com; ndabilpu...@marvell.com; > step...@networkplumber.org; pbhagavat...@marvell.com; Liang, Cunming > <cunming.li...@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>; > mattias.ronnblom <mattias.ronnb...@ericsson.com> > Subject: Re: [PATCH v11 00/16] graph enhancement for multi-core dispatch > > On Fri, Jun 9, 2023 at 3:39 PM David Marchand <david.march...@redhat.com> > wrote: > > > > On Thu, Jun 8, 2023 at 5:31 PM Jerin Jacob <jerinjac...@gmail.com> wrote: > > > On Thu, Jun 8, 2023 at 8:55 PM Zhirun Yan <zhirun....@intel.com> wrote: > > > > > > > > V11: > > > > Update comments and fix to add experimental flags for > rte_graph_model_is_valid() in patch 04. > > > > Update added symbols in alphabetical order in version.map with patch > 04,05,06,08,10. > > > > Update commit message in patch 16. > > > > > > + @Thomas Monjalon This patch series looks good from my PoV to > > > + merge > > > this in rc1. If you don't find any issue, please consider merging in > > > this rc1. > > > > Compilation is broken at patch 1 because of the file rename... > > I hope I won't find anything else broken. > > Afaics, header exports are incorrect. I did not look further. > > About headers exports: if a public header (declared in headers meson > var) includes sub_headerA,B,C, those sub headers must be listed either in > headers or indirect_headers meson variables. > Otherwise those sub headers won't be distributed for external applications > consumption.
The changed public header is used by lib/node/*, l3fwd-graph and graph-test. Actually the first patch rename the public header, and then 2nd patch change it back. It caused the broken at 1. Patch 01 and 02 are split as 2 patches because I want to retain more git history and make git log clean. I think it could be fixed by changing the used public header to the new name in patch 01, and change them back in patch 02. Is that a good way? > > For checking, I recommend running: > git rebase -i origin/main -x 'DPDK_ABI_REF_VERSION=v23.03 > DPDK_BUILD_TEST_EXAMPLES=all DPDK_BUILD_TEST_DIR=$HOME/builds/main > ./devtools/test-meson-builds.sh' > > > If we don't get fixes soon, this series will have to wait rc2 (or next > release). > > > -- > David Marchand
