On Fri, Jun 9, 2023 at 3:39 PM David Marchand <david.march...@redhat.com> wrote: > > On Thu, Jun 8, 2023 at 5:31 PM Jerin Jacob <jerinjac...@gmail.com> wrote: > > On Thu, Jun 8, 2023 at 8:55 PM Zhirun Yan <zhirun....@intel.com> wrote: > > > > > > V11: > > > Update comments and fix to add experimental flags for > > > rte_graph_model_is_valid() in patch 04. > > > Update added symbols in alphabetical order in version.map with patch > > > 04,05,06,08,10. > > > Update commit message in patch 16. > > > > + @Thomas Monjalon This patch series looks good from my PoV to merge > > this in rc1. If you don't find any issue, please consider merging in > > this rc1. > > Compilation is broken at patch 1 because of the file rename... > I hope I won't find anything else broken.
Afaics, header exports are incorrect. I did not look further. About headers exports: if a public header (declared in headers meson var) includes sub_headerA,B,C, those sub headers must be listed either in headers or indirect_headers meson variables. Otherwise those sub headers won't be distributed for external applications consumption. For checking, I recommend running: git rebase -i origin/main -x 'DPDK_ABI_REF_VERSION=v23.03 DPDK_BUILD_TEST_EXAMPLES=all DPDK_BUILD_TEST_DIR=$HOME/builds/main ./devtools/test-meson-builds.sh' If we don't get fixes soon, this series will have to wait rc2 (or next release). -- David Marchand
