> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: Wednesday, May 17, 2023 1:46 PM > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > Cc: jer...@marvell.com; dev@dpdk.org; Jayatheerthan, Jay > <jay.jayatheert...@intel.com> > Subject: Re: [PATCH v2] eventdev/eth_tx: fix runtime parameter test > > On Wed, May 17, 2023 at 11:09 AM Naga Harish K, S V > <s.v.naga.haris...@intel.com> wrote: > > > > > > > > > -----Original Message----- > > > From: Jerin Jacob <jerinjac...@gmail.com> > > > Sent: Wednesday, May 17, 2023 10:49 AM > > > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > > > Cc: jer...@marvell.com; dev@dpdk.org; Jayatheerthan, Jay > > > <jay.jayatheert...@intel.com> > > > Subject: Re: [PATCH v2] eventdev/eth_tx: fix runtime parameter test > > > > > > On Tue, May 2, 2023 at 11:27 AM Naga Harish K S V > > > <s.v.naga.haris...@intel.com> wrote: > > > > > > > > TX adapter capability check logic is simplified. > > > > The UT has been updated to skip the test, if the API to set > > > > runtime parameters is not supported. > > > > > > > > Fixes: 1d176c7add08581 ("eventdev/eth_tx: support runtime set/get > > > > parameters") > > > > > > > > Signed-off-by: Naga Harish K S V <s.v.naga.haris...@intel.com> > > > > --- > > > > app/test/test_event_eth_tx_adapter.c | 11 ++++++--- > > > > lib/eventdev/rte_event_eth_tx_adapter.c | 33 > > > > +++++-------------------- > > > > 2 files changed, 14 insertions(+), 30 deletions(-) > > > > > > > > > Please fix > > > Is it candidate for Cc: sta...@dpdk.org backport? > > > eventdev/eth_tx: fix runtime parameter test > > > > > > > This patch (feature) is added in DPDK 23.03 release. > > So, thinking this fix may need not be backported. > > Please let me know if it still needs to be backported. > > If there is stable free for 23.03 then we need to do this. > From patch author PoV(as per policy), we can mark as Cc: > sta...@dpdk.org and stable tree maintainer will do rest. > > The only case where an author does need to add Cc: sta...@dpdk.org is > when, it is fixing something in the current release where a bug is introduced > in this current release.
All review comments are addressed in V3 version of the patch.