Thank you, Tyler Retzlaff, for your comments.

> > --- a/app/test/test_memzone.c
> > +++ b/app/test/test_memzone.c
> > @@ -871,7 +871,7 @@ test_memzone_bounded(void)  static int
> >  test_memzone_free(void)
> >  {
> > -   const struct rte_memzone *mz[RTE_MAX_MEMZONE + 1];
> > +   const struct rte_memzone *mz[rte_memzone_max_get() + 1];
> 
> please no more VLAs even if in tests.
> 

VLA replaced with dynamic allocation. 

> > --- a/lib/eal/common/eal_common_memzone.c
> > +++ b/lib/eal/common/eal_common_memzone.c
> > @@ -22,6 +22,10 @@
> >  #include "eal_private.h"
> >  #include "eal_memcfg.h"
> >
> > +#define RTE_DEFAULT_MAX_MEMZONE 2560
> > +
> > +static uint32_t memzone_max = RTE_DEFAULT_MAX_MEMZONE;
> 
> should be size_t
> 

Ack

> > +int
> > +rte_memzone_max_set(uint32_t max)
> 
> max should be size_t
> 
> > +{

Ack

> > +uint32_t
> > +rte_memzone_max_get(void)
> 
> should return size_t
> 

Ack

Reply via email to