On Wed, Apr 05, 2023 at 07:25:45PM -0700, Stephen Hemminger wrote: > On Wed, 5 Apr 2023 17:45:16 -0700 > Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > > For now expand a lot of common rte macros empty. The catch here is we > > need to test that most of the macros do what they should but at the same > > time they are blocking work needed to bootstrap of the unit tests. > > > > Later we will return and provide (where possible) expansions that work > > correctly for msvc and where not possible provide some alternate macros > > to achieve the same outcome. > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > Ok, but doesn't SAL have definitions for most of these?
SAL could be used too, but i was considering that more as an integration with David's recent clang annotation additions. SAL is a broader topic since to be useful it would need to leverage tooling. depending on the macros some will come from existing msvc e.g. __declspec some will come from standard C e.g. _Noreturn many may not be critical for correct behavior but when used can decrease misuse or increase performance through better codegen. once we have things functioning correctly there will naturally be improvements in both areas that follow.
