03/04/2023 16:56, Juraj Linkeš: > On Mon, Apr 3, 2023 at 2:33 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > 03/04/2023 13:46, Juraj Linkeš: > > > Replace pexpect with Fabric. > > > > You should squash these lines with the move to Fabric. > > > > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech> > > > --- > > > dts/poetry.lock | 553 +++++++++++++++++++++++++++++++++++++++------ > > > > Do we really need *all* these lines? > > I see a lot of lines about Windows and MacOSX which are not supported in > > DTS. > > It is so long that it looks impossible to review. > > > > > This is a generated file and doesn't need to be reviewed.
In general, I don't like storing generated files. > I separated the > dependencies part so that the code part is easier to review. If you want, I > can squash the two commits. What happens if we manually remove the useless lines?
