> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: 13 March 2023 16:22
> To: Srikanth Yalavarthi <syalavar...@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarn...@marvell.com>
> Subject: [EXT] Re: [PATCH] mldev: remove weak symbols use in type
> conversions
>
> External Email
>
> ----------------------------------------------------------------------
> Hello,
>
> On Sat, Mar 11, 2023 at 3:51 PM Srikanth Yalavarthi
> <syalavar...@marvell.com> wrote:
> >
> > Drop use of weak symbols to select the type conversion functions.
> > Select NEON implementation only on Aarch64 builds. Enable windows
> > build.
> >
> > Fixes: 3c54f91ad8c9 ("mldev: disable build on Windows")
>
> Strictly speaking we are not fixing this change above, but rather
> Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
>
Updated in v2.
>
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavar...@marvell.com>
>
> The change looks good to me and the UNH Windows build target seems to
> agree :-).
Ack.
> Reviewed-by: David Marchand <david.march...@redhat.com>
>
> Thanks Srikanth.
>
>
> --
> David Marchand
