Thanks, Ferruh !
It's a good idea!
As for it involves a wide range of change, including idpf common module and
idpf pmd code,
So we'd better update it in the later fix patch after rc2.
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yi...@amd.com>
> Sent: Tuesday, February 28, 2023 5:47 AM
> To: Liu, Mingxia <mingxia....@intel.com>; dev@dpdk.org; Xing, Beilei
> <beilei.x...@intel.com>; Zhang, Yuying <yuying.zh...@intel.com>
> Subject: Re: [PATCH v7 05/21] net/cpfl: support queue start
>
> On 2/16/2023 12:29 AM, Mingxia Liu wrote:
> > Add support for these device ops:
> > - rx_queue_start
> > - tx_queue_start
> >
> > Signed-off-by: Mingxia Liu <mingxia....@intel.com>
>
> <...>
>
> > +int
> > +cpfl_rx_queue_init(struct rte_eth_dev *dev, uint16_t rx_queue_id) {
> > + struct idpf_rx_queue *rxq;
> > + int err;
> > +
> > + if (rx_queue_id >= dev->data->nb_rx_queues)
> > + return -EINVAL;
> > +
> > + rxq = dev->data->rx_queues[rx_queue_id];
> > +
> > + if (rxq == NULL || !rxq->q_set) {
> > + PMD_DRV_LOG(ERR, "RX queue %u not available or setup",
> > + rx_queue_id);
> > + return -EINVAL;
> > + }
> > +
> > + if (rxq->bufq1 == NULL) {
> > + /* Single queue */
>
> What do you think to keep the queue type explicitly in the queue struct,
> instead of deducing it from pointer values?
>
