Hi Stephen, > From: Stephen Hemminger [mailto:shemming at brocade.com] > Subject: Re: [PATCH] ixgbe: fix crc-strip enable changing rx bytes > > Harry van Haaren <harry.van.haaren at intel.com> wrote: > > <snip> > > This patch reads the CRC strip register, and when enabled adds 4 bytes > > to the total bytes recieved counter for each received packet. > > <snip> > > NAK. > > The CRC should never be part of rx/tx statistics. > > The problem with putting CRC in statistics is the behavior introduces a > device and setting dependency. This is a disaster for generic programs (like > vRouter) > that want to work across multiple hardware and virtual NIC's. > > Also, Linux, BSD, and Unix do not include CRC in reported bytes for network > interfaces. > > Please fix up my original patch to work for both settings, or I can do it.
I understand your point that generic programs should not require knowledge of if CRC bytes are included in the packet-size or not, and agree that this should be consistent in DPDK / Linux / BSD etc. I will rework the PMDs to report byte counters without CRC bytes, and mark this patch as superseded. -Harry
