On 2023/2/10 19:55, Ferruh Yigit wrote: > On 2/10/2023 1:23 AM, fengchengwen wrote: >> On 2023/2/10 7:30, Ferruh Yigit wrote: >>> On 2/9/2023 3:07 AM, Chengwen Feng wrote: >>>> The number of xstats may be large, after the hide zero option is added, >>>> only non-zero values can be displayed. >>>> >>> >>> Hi Chengwen, >>> >>> No objection on the functionality, we have similar config option in >>> testpmd too, but I have some question on telemetry side of things: >>> >>> 1) optional parameters, I don't know if there is a defined way to handle >>> this in telemetry but with current method only one optional parameter >>> can be supported and it has to be the last one. In the feature if a new >>> mandatory option required, this changes the user interface. To prevent >>> this, is it possible to use "key=value" syntax, like >>> "/ethdev/xstats,0,hide_zero=true" >>> >>> This way order or existence of multiple options doesn't matter. >> >> Yes, KV (just like PMD's runtime parameters) is more flexible for multiple >> optional parameters. >> AFAIK, only some dmadev commands have optional parameters (which using this >> patch way to identify). >> >> Until there are more parameters, I think we can keep the status quo. >> > > I think better to start using it with first optional parameter, which is > this patch, otherwise it will be pushing the work to next contributor.
v2 implements it, please review, thanks. > >>> >>> >>> 2) Where should be this functionality, it is possible to filter out zero >>> values either in dpdk side or telemetry client side. >>> Just for this one I think both options are OK, but if there is a >>> possibility to have multiple and complex filtering, I think that should >>> go to the client side since this is not really task of the dpdk library. >> >> Agree. >> This patch just target who using telemetry.py directly, it's valuable in >> this scenario. >> If clients supports filtering, they could use original way (don't add >> options). >> > > OK, I don't have strong option, if there is no objection we can have > this functionality in dpdk side. > >> Thanks. >> >>> >>> >>>> Signed-off-by: Chengwen Feng <fengcheng...@huawei.com> >>>> --- ...
