On 2023/2/1 0:44, Honnappa Nagarahalli wrote:
Few minor comments inline. Otherwise,
Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
Thanks for your review.
-----Original Message-----
From: Jie Hai <haij...@huawei.com>
Sent: Monday, January 30, 2023 8:29 PM
To: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>;
konstantin.v.anan...@yandex.ru; dev@dpdk.org
Cc: liudongdo...@huawei.com; haij...@huawei.com
Subject: [PATCH v3 1/2] ring: add ring list telemetry cmd
How about "ring: add telemetry cmd to list rings"
This patch supports the list of rings with telemetry cmd.
Add a telemetry command to list the rings used in the system.
That sounds easier to understand. Accepted and will change it in v4.
An example using this command is shown below:
--> /ring/list
{
"/ring/list": [
"HT_0000:7d:00.2",
"MP_mb_pool_0"
]
}
+RTE_INIT(ring_init_telemetry)
+{
+ rte_telemetry_register_cmd("/ring/list", ring_handle_list,
+ "Returns list of available ring. Takes no parameters"); }
^^^^
rings
Thank you very much for your comments. I will change it to "Returns list
of available rings" in v4.
--
2.33.0
.
