On 2023/2/1 0:44, Honnappa Nagarahalli wrote:
Few minor nits. Otherwise,
Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
Thanks for your review.
-----Original Message-----
From: Jie Hai <haij...@huawei.com>
Sent: Monday, January 30, 2023 8:29 PM
To: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>;
konstantin.v.anan...@yandex.ru; dev@dpdk.org
Cc: liudongdo...@huawei.com; haij...@huawei.com
Subject: [PATCH v3 2/2] ring: add ring info telemetry cmd
"ring: add telemetry cmd for ring info"
This patch supports dump of the info of ring by its name.
This patch supports dump of ring information by its name.
Accepted and will change it in v4.
An example using this command is shown below:
--> /ring/info,MP_mb_pool_0
{
"/ring/info": {
"name": "MP_mb_pool_0",
"socket": 0,
"flags": 0,
"producer_type": "MP",
"consumer_type": "MC",
"size": 262144,
"mask": 262143,
"capacity": 262143,
"used_count": 147173,
"consumer_tail": 8283,
"consumer_head": 8283,
"producer_tail": 155456,
"producer_head": 155456,
Sometimes it is much easier to understand these numbers if they are in
hexadecimal. Is it possible to add the hexadecimal format in brackets?
Something like:
"size": 262144 (0x40000)
Huisong Li <lihuis...@huawei.com> makes it possible in
http://patches.dpdk.org/project/dpdk/patch/20221219070648.33817-7-lihuis...@huawei.com/.
We can change rte_tel_data_add_dict_u64 to
rte_tel_data_add_dict_uint_hex after his patch accepted.
--
2.33.0
.
