On Wed, Feb 1, 2023 at 10:27 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > 28/01/2023 12:27, Jerin Jacob: > > I see main comments are on param update and get the capablities. > > To enable that, please propose the changes around > > rte_ml_model_params_update(), > > rte_ml_model_info. We should able to take that and send v2. > > Sorry I don't have the bandwidth to work on mldev now.
Understandable. > I understand you took the easy path of opaque pointer, I would say not easy path, rather the use case I am not aware of and the model that we are supporting. > and you are OK to refine it if needed. Yes > Because there is not much reviews, I think we should merge it as-is > and keep it experimental the time needed to have more feedbacks > and a second vendor implementing it. Ack.I think, it is reasonable the first patch was pushed on Aug3. It was around 6 months for reviews. https://inbox.dpdk.org/dev/20220803132839.2747858-2-jer...@marvell.com/ > >
