25/01/2023 14:25, Srikanth Yalavarthi: > From: Thomas Monjalon <tho...@monjalon.net> > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > This patch series implements the common ML code that can be used by ML > > > drivers. Common code include functions to convert ML IO type to > > > string, IO format type to string, function get size of ML IO type, and > > > functions for converting data types from higher precision to lower > > > precision and vice-versa. > > > > I'm not sure about the path of this code. > > In general we implement drivers helper in the same directory as the driver > > and mark it as internal. > > Would it work here? > > We are planning to implement two different ML drivers, ml/cnxk driver > (submitted for review) and a software only driver (part of ML roadmap and > currently WIP). Both the drivers would be using these common functions for > quantization and dequantization. Hence, placed the files in common/ml > directory. > > Moreover, these functions are used to convert data from higher to lower > precision or vice-versa and can also be used by future ML drivers for other > platforms.
I understand, and what you say does not contradict with having this code in lib/mldev/. So would you agree to move?
