> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 19 January 2023 19.46 > > vhost internals involves multiple locks to protect data access by > multiple threads. > > This series uses clang thread safety checks [1] to catch issues during > compilation: EAL spinlock, seqlock and rwlock are annotated and vhost > code is instrumented so that clang can statically check correctness. > > Those annotations are quite heavy to maintain because the full path of > code must be annotated (as can be seen in the vhost datapath code), > but I think it is worth using. > > This has been tested against the whole tree and some fixes are already > flying on the mailing list (see [2] for a list). > > If this first series is merged, I will prepare a followup series for > EAL > and other libraries. > > > 1: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html > 2: > https://patchwork.dpdk.org/bundle/dmarchand/lock_fixes/?state=*&archive > =both > > --
Lock annotations seems like a good idea. I probably didn't notice the previous patch versions because the email subject camouflaged them as "vhost something...", so I skipped them. Series-acked-by: Morten Brørup <m...@smartsharesystems.com>
