For the multiple hardware ports connect to a single DPDK port (mhpsdp), the previous patch introduces the new rte flow item to match the port affinity of the received packets.
This patch adds the tx_affinity setting in Tx queue API, the affinity value reflects packets be sent to which hardware port. Adds the new tx_affinity field into the padding hole of rte_eth_txconf structure, the size of rte_eth_txconf keeps the same. Adds a suppress type for structure change in the ABI check file. This patch adds the testpmd command line: testpmd> port config (port_id) txq (queue_id) affinity (value) For example, there're two hardware ports connects to a single DPDK port (port id 0), and affinity 1 stood for hard port 1 and affinity 2 stood for hardware port 2, used the below command to config tx affinity for each TxQ: port config 0 txq 0 affinity 1 port config 0 txq 1 affinity 1 port config 0 txq 2 affinity 2 port config 0 txq 3 affinity 2 These commands config the TxQ index 0 and TxQ index 1 with affinity 1, uses TxQ 0 or TxQ 1 send packets, these packets will be sent from the hardware port 1, and similar with hardware port 2 if sending packets with TxQ 2 or TxQ 3. Signed-off-by: Jiawei Wang <jiaw...@nvidia.com> --- app/test-pmd/cmdline.c | 84 +++++++++++++++++++++ devtools/libabigail.abignore | 5 ++ doc/guides/rel_notes/release_22_03.rst | 4 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 13 ++++ lib/ethdev/rte_ethdev.h | 1 + 5 files changed, 107 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b32dc8bfd4..683cae1cab 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -764,6 +764,10 @@ static void cmd_help_long_parsed(void *parsed_result, "port cleanup (port_id) txq (queue_id) (free_cnt)\n" " Cleanup txq mbufs for a specific Tx queue\n\n" + + "port config <port_id> txq <queue_id> affinity <value>\n" + " Set the port affinity value " + "on a specific Tx queue\n\n" ); } @@ -12621,6 +12625,85 @@ static cmdline_parse_inst_t cmd_show_port_flow_transfer_proxy = { } }; +/* *** configure port txq affinity value *** */ +struct cmd_config_tx_affinity { + cmdline_fixed_string_t port; + cmdline_fixed_string_t config; + portid_t portid; + cmdline_fixed_string_t txq; + uint16_t qid; + cmdline_fixed_string_t affinity; + uint16_t value; +}; + +static void +cmd_config_tx_affinity_parsed(void *parsed_result, + __rte_unused struct cmdline *cl, + __rte_unused void *data) +{ + struct cmd_config_tx_affinity *res = parsed_result; + struct rte_port *port; + + if (port_id_is_invalid(res->portid, ENABLED_WARN)) + return; + + if (res->portid == (portid_t)RTE_PORT_ALL) { + printf("Invalid port id\n"); + return; + } + + port = &ports[res->portid]; + + if (strcmp(res->txq, "txq")) { + printf("Unknown parameter\n"); + return; + } + if (tx_queue_id_is_invalid(res->qid)) + return; + + port->txq[res->qid].conf.tx_affinity = res->value; + + cmd_reconfig_device_queue(res->portid, 0, 1); +} + +cmdline_parse_token_string_t cmd_config_tx_affinity_port = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_affinity, + port, "port"); +cmdline_parse_token_string_t cmd_config_tx_affinity_config = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_affinity, + config, "config"); +cmdline_parse_token_num_t cmd_config_tx_affinity_portid = + TOKEN_NUM_INITIALIZER(struct cmd_config_tx_affinity, + portid, RTE_UINT16); +cmdline_parse_token_string_t cmd_config_tx_affinity_txq = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_affinity, + txq, "txq"); +cmdline_parse_token_num_t cmd_config_tx_affinity_qid = + TOKEN_NUM_INITIALIZER(struct cmd_config_tx_affinity, + qid, RTE_UINT16); +cmdline_parse_token_string_t cmd_config_tx_affinity_affine = + TOKEN_STRING_INITIALIZER(struct cmd_config_tx_affinity, + affinity, "affinity"); +cmdline_parse_token_num_t cmd_config_tx_affinity_value = + TOKEN_NUM_INITIALIZER(struct cmd_config_tx_affinity, + value, RTE_UINT16); + +static cmdline_parse_inst_t cmd_config_tx_affinity = { + .f = cmd_config_tx_affinity_parsed, + .data = (void *)0, + .help_str = "port config <port_id> txq <queue_id> affinity <value>", + .tokens = { + (void *)&cmd_config_tx_affinity_port, + (void *)&cmd_config_tx_affinity_config, + (void *)&cmd_config_tx_affinity_portid, + (void *)&cmd_config_tx_affinity_txq, + (void *)&cmd_config_tx_affinity_qid, + (void *)&cmd_config_tx_affinity_affine, + (void *)&cmd_config_tx_affinity_value, + NULL, + }, +}; + /* ******************************************************************************** */ /* list of instructions */ @@ -12851,6 +12934,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = { (cmdline_parse_inst_t *)&cmd_show_capability, (cmdline_parse_inst_t *)&cmd_set_flex_is_pattern, (cmdline_parse_inst_t *)&cmd_set_flex_spec_pattern, + (cmdline_parse_inst_t *)&cmd_config_tx_affinity, NULL, }; diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 7a93de3ba1..cbbde4ef05 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -20,6 +20,11 @@ [suppress_file] soname_regexp = ^librte_.*mlx.*glue\. +; Ignore fields inserted in middle padding of rte_eth_txconf +[suppress_type] + name = rte_eth_txconf + has_data_member_inserted_between = {offset_after(tx_deferred_start), offset_of(offloads)} + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ; Experimental APIs exceptions ; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst index 8acd3174f6..0d81ae7bc3 100644 --- a/doc/guides/rel_notes/release_22_03.rst +++ b/doc/guides/rel_notes/release_22_03.rst @@ -212,6 +212,10 @@ API Changes * ethdev: Old public macros and enumeration constants without ``RTE_ETH_`` prefix, which are kept for backward compatibility, are marked as deprecated. +* ethdev: added a new field: + + - Tx affinity per-queue ``rte_eth_txconf.tx_affinity`` + * cryptodev: The asymmetric session handling was modified to use a single mempool object. An API ``rte_cryptodev_asym_session_pool_create`` was added to create a mempool with element size big enough to hold the generic asymmetric diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index c0ace56c1f..0c3317ee06 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1605,6 +1605,19 @@ Enable or disable a per queue Tx offloading only on a specific Tx queue:: This command should be run when the port is stopped, or else it will fail. +config per queue Tx affinity +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +Configure a affinity value per queue Tx offloading only on a specific Tx queue:: + + testpmd> port (port_id) txq (queue_id) affinity (value) + +* ``affinity``: reflects packet can be sent to which hardware port. + uses it on multiple hardware ports connect to + a single DPDK port (mhpsdp). + +This command should be run when the port is stopped, or else it will fail. + Config VXLAN Encap outer layers ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 882ca585f2..813dbb34b5 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -1138,6 +1138,7 @@ struct rte_eth_txconf { less free descriptors than this value. */ uint8_t tx_deferred_start; /**< Do not start queue with rte_eth_dev_start(). */ + uint8_t tx_affinity; /**< Drives the setting of affinity per-queue. */ /** * Per-queue Tx offloads to be set using RTE_ETH_TX_OFFLOAD_* flags. * Only offloads set on tx_queue_offload_capa or tx_offload_capa -- 2.18.1