在 2022/12/15 1:53, Tyler Retzlaff 写道:
On Tue, Dec 13, 2022 at 09:19:45PM +0100, Morten Brørup wrote:
From: Bruce Richardson [mailto:bruce.richard...@intel.com]
Sent: Tuesday, 13 December 2022 19.28
While the unsigned values added to telemetry dicts/arrays were up to
64-bits in size, the sized values were only up to 32-bits. We can
standardize the API by having both int and uint functions take 64-bit
values. For ABI compatibility, we use function versioning to ensure
older binaries can still use the older functions taking a 32-bit
parameter.
Suggested-by: Morten Brørup <m...@smartsharesystems.com>
Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
---
Excellent example of how to use function versioning for ABI compatibility.
Series-acked-by: Morten Brørup <m...@smartsharesystems.com>
minor comments that can be optionally addressed. lgtm
Series-acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
.
LGTM
Series-acked-by: Huisong Li <lihuis...@huawei.com>
But I feel this patchset needs to be applied after the following patchset:
http://patches.dpdk.org/project/dpdk/list/?series=26124
The above patchset fixes some problems about possible data truncation and
conversion error, and will backport to stable branch.
