On Tue, Dec 13, 2022 at 09:19:45PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, 13 December 2022 19.28 > > > > While the unsigned values added to telemetry dicts/arrays were up to > > 64-bits in size, the sized values were only up to 32-bits. We can > > standardize the API by having both int and uint functions take 64-bit > > values. For ABI compatibility, we use function versioning to ensure > > older binaries can still use the older functions taking a 32-bit > > parameter. > > > > Suggested-by: Morten Brørup <m...@smartsharesystems.com> > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > --- > > Excellent example of how to use function versioning for ABI compatibility. > > Series-acked-by: Morten Brørup <m...@smartsharesystems.com> >
minor comments that can be optionally addressed. lgtm Series-acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
