On Fri, Dec 2, 2022 at 2:39 PM Aaron Conole <acon...@redhat.com> wrote:
>
> David Marchand <david.march...@redhat.com> writes:
>
> > ld exports any global symbol by default if no version script is passed.
> > As a consequence, the incriminated change let any public symbol leak
> > out of the driver shared libraries.
> >
> > Hide again those symbols by providing a default map file which
> > unexports any global symbol using a local: * catch-all statement.
> >
> > The checks are skipped for this default map file as it is intentionnally
> > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol
> > maps")) and there is nothing else to check in this map.
> >
> > This change impacts the exported symbols, hence, bump the version in the
> > ABI check to the v22.11.1 from the 22.11 LTS branch.
> >
> > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded")
> > Cc: sta...@dpdk.org
> >
> > Reported-by: Luca Boccassi <luca.bocca...@microsoft.com>
> > Signed-off-by: David Marchand <david.march...@redhat.com>
> > Tested-by: Ferruh Yigit <ferruh.yi...@amd.com>
> > Reviewed-by: Bruce Richardson <bruce.richard...@intel.com>
> Acked-by: Aaron Conole <acon...@redhat.com>Series applied. Please, maintainers and CI teams, when you enable ABI checks in the main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 tag as a reference. Thanks. -- David Marchand
