On 11/30/2022 10:02 AM, David Marchand wrote: > ld exports any global symbol by default if no version script is passed. > As a consequence, the incriminated change let any public symbol leak > out of the driver shared libraries. > > Hide again those symbols by providing a default map file which > unexports any global symbol using a local: * catch-all statement. > > The checks are skipped for this default map file as it is intentionnally > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > maps")) and there is nothing else to check in this map. > > While at it, move Windows specific objects where needed for better > readability. > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > Cc: sta...@dpdk.org > > Reported-by: Luca Boccassi <luca.bocca...@microsoft.com> > Signed-off-by: David Marchand <david.march...@redhat.com> > Tested-by: Ferruh Yigit <ferruh.yi...@amd.com>
Tested v2, looks good. 'check-symbol-maps.sh' warning fixed too.