Morten Brørup, Nov 28, 2022 at 11:52: > Consider adding the percentage here, for easy human consumption: > > ", busy cycles %"PRIu64"/%"PRIu64" (%.02f%%)", > busy_cycles, total_cycles, > busy_cycles ? (float)busy_cycles / (float)total_cycles * (float)100); > > On the other hand, it is the average over the total uptime, so the > percentage might only be useful for very few cases.
I had thought adding the percentage. But as you said, I'm not sure how this can be of interest. I can add it in v3 if needed. > Same comment about coding convention: > if (lcore_usage_cb != NULL && lcore_usage_cb(... Will fix that in v3. > Looks good to me. > > And we could probably discuss naming forever... "Usage" and > "utilization" are synonyms, but usage is shorter, so let's stick with > that. > > Acked-by: Morten Brørup <m...@smartsharesystems.com> Thanks. I'll do s/utilization/usage/g for v3.
