On Thu, Nov 24, 2022 at 06:19:57PM +0100, Thomas Monjalon wrote: > 24/11/2022 17:51, Stephen Hemminger: > > On Thu, 24 Nov 2022 13:43:07 +0000 > > Bruce Richardson <bruce.richard...@intel.com> wrote: > > > > > On Thu, Nov 24, 2022 at 01:13:20PM +0100, David Marchand wrote: > > > > From: Bruce Richardson <bruce.richard...@intel.com> > > > > > > > > Since a number of contributors to DPDK have submitted patches to DPDK > > > > under more than one email address, we should maintain a mailmap file to > > > > properly track their commits using "shortlog". > > > > > > > > It also helps fix up any mangled names, for example, with > > > > surname/firstname reversed, or with incorrect capitalization. > > > > By keeping this file in the DPDK repository, rather than committers > > > > maintaining their own copies, it allows individual contributors to edit > > > > it to update their own email address preferences if so desired. > > > > > > > > While at it, update our checkpatches.sh script and add some > > > > documentation to help new contributors. > > > > > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > > > --- > > > > Changes since v3: > > > > - fixed some issues with non iso characters in names, > > > > - added .mailmap to MAINTAINERS, > > > > - populated .mailmap with the contributors file Thomas and I maintain, > > > > - added a check so that people will stop mangling their own names, > > > > - added a note in the contributing guide, > > > > > > > Do we really want to require all contributors to add their names to the > > > mailmap file, it seems excessive to me and onerous on new contributors? I > > > would expect the mailmap to be only necessary for tracking mail updates, > > > or > > > fixing already-mangled names. > > > > > > /Bruce > > > > Isn't mailmap only needed when there are multiple email addresses in the > > commit log? > > Yes, but we also want the full list in order to make sure > there is no typo when writing name or email. > That's the dirty job maintainers are doing... > >
coming to the party late, does this fix the problem of the CI rejecting patches that have @microsoft.com vs @linux.microsoft.com for me? because if it does i'm on board with this change. this arises for me if i work on my "work" provided systems which use a default user.email, if i don't notice then it's stuck in the history and i have to stuff around to fix the commits. thanks for doing this.
