24/11/2022 16:08, Bruce Richardson: > On Thu, Nov 24, 2022 at 02:57:17PM +0100, Thomas Monjalon wrote: > > 24/11/2022 14:49, David Marchand: > > > On Thu, Nov 24, 2022 at 2:43 PM Bruce Richardson > > > <bruce.richard...@intel.com> wrote: > > > > > > > > On Thu, Nov 24, 2022 at 01:13:20PM +0100, David Marchand wrote: > > > > > From: Bruce Richardson <bruce.richard...@intel.com> > > > > > > > > > > Since a number of contributors to DPDK have submitted patches to DPDK > > > > > under more than one email address, we should maintain a mailmap file > > > > > to > > > > > properly track their commits using "shortlog". > > > > > > > > > > It also helps fix up any mangled names, for example, with > > > > > surname/firstname reversed, or with incorrect capitalization. > > > > > By keeping this file in the DPDK repository, rather than committers > > > > > maintaining their own copies, it allows individual contributors to > > > > > edit > > > > > it to update their own email address preferences if so desired. > > > > > > > > > > While at it, update our checkpatches.sh script and add some > > > > > documentation to help new contributors. > > > > > > > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > > > > --- > > > > > Changes since v3: > > > > > - fixed some issues with non iso characters in names, > > > > > - added .mailmap to MAINTAINERS, > > > > > - populated .mailmap with the contributors file Thomas and I maintain, > > > > > - added a check so that people will stop mangling their own names, > > > > > - added a note in the contributing guide, > > > > > > > > > Do we really want to require all contributors to add their names to the > > > > mailmap file, it seems excessive to me and onerous on new contributors? > > > > I > > > > would expect the mailmap to be only necessary for tracking mail > > > > updates, or > > > > fixing already-mangled names. > > > > > > As someone who checks those names and fixes some regularly, I prefer > > > developers check this themselves. > > > > If a new contributor does not edit this file, it can be done while merging. > > > That would be ok, I think. I just don't want to have extra hurdles for new > contributors to jump through. Thanks for this.
I won't be mandatory and it's very easy. We'll run the check and will fix it as maintainers.
