On 11/10/2022 10:02 AM, Huzaifa Rahman wrote:
Hi,
Is there any other work/changes required for this patch to be submitted?
Hi Huzaifa,
Patch seems already merged by Andrew and pulled to main repo:
https://git.dpdk.org/dpdk/commit/?id=231435a5e6c7fa915697d8f84a91b44176
So it will in oncoming 22.11 release.
Thanks
On Tue, Oct 4, 2022 at 7:53 PM Andrew Rybchenko
<andrew.rybche...@oktetlabs.ru <mailto:andrew.rybche...@oktetlabs.ru>>
wrote:
On 8/8/22 13:39, Joyce Kong wrote:
> Hi Huzaifa,
>
> This patch looks good to me.
> And would you please help review my memif patches?
>
https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.k...@arm.com/
<https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.k...@arm.com/>
>
> Thanks,
> Joyce
>
>> -----Original Message-----
>> From: huzaifa.rahman <huzaifa.rah...@emumba.com
<mailto:huzaifa.rah...@emumba.com>>
>> Sent: Tuesday, July 26, 2022 6:16 PM
>> To: jgraj...@cisco.com <mailto:jgraj...@cisco.com>
>> Cc: dev@dpdk.org <mailto:dev@dpdk.org>; huzaifa.rahman
<huzaifa.rah...@emumba.com <mailto:huzaifa.rah...@emumba.com>>
>> Subject: [PATCH] memif: memif driver does not crashes when there's
>> different N of TX and RX queues
> net/memif: fix memif crash with different Tx Rx queues
>
>>
>> Bugzilla ID: 734
>>
>> there's a bug in memif_stats_get() function due to confusion
between C2S
>> (client->server) and S2C (server->client) rings, causing a crash
if there's a
>> different number of RX and TX queues.
>>
>> this is fixed by selectiing the correct rings for RX and TX i.e
for RX, S2C rings
>> are selected and for TX, C2S rings are selected.
>>
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> Cc: sta...@dpdk.org <mailto:sta...@dpdk.org>
>
>> Signed-off-by: huzaifa.rahman <huzaifa.rah...@emumba.com
<mailto:huzaifa.rah...@emumba.com>>
> Reviewed-by: Joyce Kong <joyce.k...@arm.com
<mailto:joyce.k...@arm.com>>
Fixed above on applying.
Applied to dpdk-next-net/main, thanks.