BR Rongwei
> -----Original Message----- > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > Sent: Sunday, November 6, 2022 18:03 > To: Rongwei Liu <rongw...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; > Slava Ovsiienko <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>; > NBU-Contact-Thomas Monjalon (EXTERNAL) <tho...@monjalon.net>; Aman > Singh <aman.deep.si...@intel.com>; Yuying Zhang > <yuying.zh...@intel.com>; Ferruh Yigit <ferruh.yi...@amd.com> > Cc: dev@dpdk.org; Raslan Darawsheh <rasl...@nvidia.com> > Subject: Re: [PATCH v3] ethdev: add hint when creating async transfer table > > External email: Use caution opening links or attachments > > > On 10/4/22 11:31, Andrew Rybchenko wrote: > > On 9/28/22 12:24, Rongwei Liu wrote: > >> The transfer domain rule is able to match traffic wire/vf origin and > >> it means two directions' underlayer resource. > >> > >> In customer deployments, they usually match only one direction > >> traffic in single flow table: either from wire or from vf. > >> > >> Introduce one new member transfer_mode into > >> rte_flow_template_table_attr to indicate the flow table direction > >> property: from wire, from vf or bi-direction(default). > >> > >> It helps to save underlayer memory also on insertion rate, and this > >> new field doesn't expose any matching criteira. > >> > >> By default, the transfer domain is to match bi-direction traffic, and > >> no behavior changed. > >> > >> 1. Match wire origin only > >> flow template_table 0 create group 0 priority 0 transfer wire_orig... > >> 2. Match vf origin only > >> flow template_table 0 create group 0 priority 0 transfer vf_orig... > > > > Since wire_orig and vf_orig are just optional hints and not all PMDs > > are obliged to handle it, it does not impose any matching criteria. > > So, example above are misleading and you need to add pattern items to > > highlight that corresponding rules are really wire_orig or vf_orig. > > I'm sorry, but I still don't see how it is addressed in v4. @Thomas Monjalon Could you share some thoughts? Thanks. > > > > >> > >> Signed-off-by: Rongwei Liu <rongw...@nvidia.com> > >> Acked-by: Ori Kam <or...@nvidia.com> > > > > [snip] > >
