Hi Kai,
A couple of minor bits left.
> -----Original Message-----
> From: Ji, Kai <kai...@intel.com>
> Sent: Wednesday, October 26, 2022 11:28 AM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; Ji, Kai <kai...@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>; Burakov, Anatoly
> <anatoly.bura...@intel.com>
> Subject: [dpdk-dev v4] crypto/ipsec_mb: multi-process IPC request handler
>
> As the queue pair used in secondary process need to be setuped by the
needs/needed to be set up by...
> primary process, this patch add an IPC register function to help secondary
This patch adds
> process to send out queue-pair setup reguest to primary process via IPC
request
> messages. A new "qp_in_used_pid" param stores the PID to provide the
> ownership of the queue-pair so that only the PID matched queue-pair can be
> free'd in the request.
>
> Signed-off-by: Kai Ji <kai...@intel.com>
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.h
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.h
> @@ -25,6 +25,9 @@
> /* Maximum length for memzone name */
> #define IPSEC_MB_MAX_MZ_NAME 32
>
> +/* ipsec mb multi-process queue pair config */ #define
> IPSEC_MB_MP_MSG
> +"ipsec_mb_mp_msg"
> +
> enum ipsec_mb_vector_mode {
> IPSEC_MB_NOT_SUPPORTED = 0,
> IPSEC_MB_SSE,
> @@ -142,18 +145,49 @@ struct ipsec_mb_qp {
> enum ipsec_mb_pmd_types pmd_type;
> /**< pmd type */
> uint8_t digest_idx;
> + /**< The process id used for queue pairs **/
> + uint16_t qp_used_by_pid;
> /**< Index of the next
> * slot to be used in temp_digests,
> * to store the digest for a given operation
> */
Comments are mixed here (digest_idx and qp_used_by_pid).
> IMB_MGR *mb_mgr;
> - /* Multi buffer manager */
> + /**< Multi buffer manager */
> const struct rte_memzone *mb_mgr_mz;
> - /* Shared memzone for storing mb_mgr */
> + /**< Shared memzone for storing mb_mgr */
> __extension__ uint8_t additional_data[];
> /**< Storing PMD specific additional data */ };
>
