Hi, Akhil Thanks for your guidance.
On Tue, 25 Oct 2022 at 23:02, Akhil Goyal <gak...@marvell.com> wrote: > > > > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. > > > > UADK is a framework for user applications to access hardware accelerators. > > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > > the same page table between IOMMU and MMU. > > Thereby user application can directly use virtual address for device dma, > > which enhances the performance as well as easy usability. > > > > [1] https://github.com/Linaro/uadk > > > > Test: > > sudo dpdk-test --vdev=crypto_uadk (--log-level=6) > > RTE>>cryptodev_uadk_autotest > > RTE>>quit > > > > resend: > > fix uadk lib, still use <uadk/wd_cipher.h> > > There is nothing called as resend in DPDK ML. > Please simply increment version number each time you send the set. > > > Also add release notes update in the patch > where the driver implementation is complete. > > Compilation issues are all done now. > Have sent some other comments on the patches. Please send the v6 ASAP. > We need to close RC2 in a couple of days. > Got it, have addressed the comments and updated to v6 https://github.com/Linaro/dpdk/commits/next-9.11-v6 Will send tonight. Some uncertainty 1. The updated uadk.rst https://github.com/Linaro/dpdk/blob/next-9.11-v6/doc/guides/cryptodevs/uadk.rst 2. About the release notes change, Do I add a new patch in the last: 07 https://github.com/Linaro/dpdk/commit/f2294300662def012e00d5a3c5466bbf8436904b Or merge it to the first patch 01. 3. I update uadk.rst and test in the same patch, is that OK. https://github.com/Linaro/dpdk/commit/4be993e9995def1061dcfdd7863a7f2ba6d5da6c Thanks