On Tue, Oct 04, 2022 at 09:30:39AM +0300, Omer Yamac wrote:
>
>
> On 03.10.2022 17:01, Bruce Richardson wrote:
> > On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote:
> > >
> > >
> > > On 03.10.2022 12:19, Bruce Richardson wrote:
> > > > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
> > > > > In this patch, we remove all version.map files which include
> > > > > only the below part:
> > > > > `DPDK_23 {
> > > > > local: *;
> > > > > };`
> > > > >
> > > > > Then we modify the meson.build to be able to compile without
> > > > > version.map
> > > > >
> > > > > Signed-off-by: Abdullah Ömer Yamaç <omer.ya...@ceng.metu.edu.tr>
> > > > > Suggested-by: Ferruh Yigit <ferruh.yi...@amd.com>
> > > > > ---
> > > >
> > > > I think you need to flag this as depending on us bumping the meson
> > > > version
> > > > requirement up to 0.53 as has been proposed. This doesn't work with 0.4x
> > > > versions.
> > > >
> > > Thanks for your warnings.
> > > Instead of using fs module, I will use python script that checks
> > > file exist
> > > or not.
> > > If it is okay, I will resubmit the patch.
> >
> > I'd rather not go down that road unless we really need to. Right now the
> > empty version.map files are pretty much harmless, so there is no
> > compelling
> > need to change. Therefore, I'd rather wait to have the meson version
> > bumped
> > to 0.53 and then have this patch applied, without having to worry about
> > using script fallbacks.
> I understood; but one thing I'm not sure what should I do? I don't know how
> can I flag the meson requirement. Is there any special method or just a
> comment in the commit?
You can just put a note in the commit log, under a cut-line indicating what
other patches your patch depends upon.
See https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies
Regards,
/Bruce
