[PATCH v2 8/9] trace: remove limitation on trace point name

[David Marchand]

The name of a trace point is provided as a constant string via the
RTE_TRACE_POINT_REGISTER macro.
We can rely on the constant string in the binary and simply point at it.
There is then no need for a (fixed size) copy.

Signed-off-by: David Marchand <david.march...@redhat.com>
---
 lib/eal/common/eal_common_trace.c       | 10 +++-------
 lib/eal/common/eal_common_trace_utils.c |  2 +-
 lib/eal/common/eal_trace.h              |  3 +--
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/lib/eal/common/eal_common_trace.c 
b/lib/eal/common/eal_common_trace.c
index ec168e37b3..5caaac8e59 100644
--- a/lib/eal/common/eal_common_trace.c
+++ b/lib/eal/common/eal_common_trace.c
@@ -235,7 +235,7 @@ rte_trace_point_lookup(const char *name)
                return NULL;
 
        STAILQ_FOREACH(tp, &tp_list, next)
-               if (strncmp(tp->name, name, TRACE_POINT_NAME_SIZE) == 0)
+               if (strcmp(tp->name, name) == 0)
                        return tp->handle;
 
        return NULL;
@@ -492,10 +492,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, 
const char *name,
        }
 
        /* Initialize the trace point */
-       if (rte_strscpy(tp->name, name, TRACE_POINT_NAME_SIZE) < 0) {
-               trace_err("name is too long");
-               goto free;
-       }
+       tp->name = name;
 
        /* Copy the accumulated fields description and clear it for the next
         * trace point.
@@ -517,8 +514,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const 
char *name,
 
        /* All Good !!! */
        return 0;
-free:
-       free(tp);
+
 fail:
        if (trace.register_errno == 0)
                trace.register_errno = rte_errno;
diff --git a/lib/eal/common/eal_common_trace_utils.c 
b/lib/eal/common/eal_common_trace_utils.c
index 7bf1c05e12..72108d36a6 100644
--- a/lib/eal/common/eal_common_trace_utils.c
+++ b/lib/eal/common/eal_common_trace_utils.c
@@ -42,7 +42,7 @@ trace_entry_compare(const char *name)
        int count = 0;
 
        STAILQ_FOREACH(tp, tp_list, next) {
-               if (strncmp(tp->name, name, TRACE_POINT_NAME_SIZE) == 0)
+               if (strcmp(tp->name, name) == 0)
                        count++;
                if (count > 1) {
                        trace_err("found duplicate entry %s", name);
diff --git a/lib/eal/common/eal_trace.h b/lib/eal/common/eal_trace.h
index 72a5a461ae..26a18a2c48 100644
--- a/lib/eal/common/eal_trace.h
+++ b/lib/eal/common/eal_trace.h
@@ -24,14 +24,13 @@
 
 #define TRACE_PREFIX_LEN 12
 #define TRACE_DIR_STR_LEN (sizeof("YYYY-mm-dd-AM-HH-MM-SS") + TRACE_PREFIX_LEN)
-#define TRACE_POINT_NAME_SIZE 64
 #define TRACE_CTF_MAGIC 0xC1FC1FC1
 #define TRACE_MAX_ARGS 32
 
 struct trace_point {
        STAILQ_ENTRY(trace_point) next;
        rte_trace_point_t *handle;
-       char name[TRACE_POINT_NAME_SIZE];
+       const char *name;
        char *ctf_field;
 };
 
-- 
2.37.3