> Subject: Re: [Patch v8 01/18] net/mana: add basic driver with build
> environment and doc
> 
> On 9/8/2022 10:56 PM, lon...@linuxonhyperv.com wrote:
> > From: Long Li<lon...@microsoft.com>
> >
> > MANA is a PCI device. It uses IB verbs to access hardware through the
> > kernel RDMA layer. This patch introduces build environment and basic
> > device probe functions.
> >
> > Signed-off-by: Long Li<lon...@microsoft.com>
> > ---
> > Change log:
> > v2:
> > Fix typos.
> > Make the driver build only on x86-64 and Linux.
> > Remove unused header files.
> > Change port definition to uint16_t or uint8_t (for IB).
> > Use getline() in place of fgets() to read and truncate a line.
> > v3:
> > Add meson build check for required functions from RDMA direct verb
> > header file
> > v4:
> > Remove extra "\n" in logging code.
> > Use "r" in place of "rb" in fopen() to read text files.
> > v7:
> > Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap.
> > v8:
> > Add clarification on driver args usage to nics guide.
> > Fix coding sytle on function definitions.
> > Use different variable names in MANA_MKSTR.
> > Use MANA_ prefix for all macros.
> > Use RTE_PMD_REGISTER_PCI in place of rte_pci_register.
> > Add .vendor_id = 0 to the end of PCI table.
> > Remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS from dev_flags.
> >
> >   MAINTAINERS                       |   6 +
> >   doc/guides/nics/features/mana.ini |  10 +
> >   doc/guides/nics/index.rst         |   1 +
> >   doc/guides/nics/mana.rst          |  69 +++
> >   drivers/net/mana/mana.c           | 728
> ++++++++++++++++++++++++++++++
> >   drivers/net/mana/mana.h           | 207 +++++++++
> >   drivers/net/mana/meson.build      |  44 ++
> >   drivers/net/mana/mp.c             | 241 ++++++++++
> >   drivers/net/mana/version.map      |   3 +
> >   drivers/net/meson.build           |   1 +
> >   10 files changed, 1310 insertions(+)
> >   create mode 100644 doc/guides/nics/features/mana.ini
> >   create mode 100644 doc/guides/nics/mana.rst
> >   create mode 100644 drivers/net/mana/mana.c
> >   create mode 100644 drivers/net/mana/mana.h
> >   create mode 100644 drivers/net/mana/meson.build
> >   create mode 100644 drivers/net/mana/mp.c
> >   create mode 100644 drivers/net/mana/version.map
> 
> Can you please run './devtools/check-meson.py', it complains about
> 'drivers/net/mana/meson.build'?

Will fix this.

Thanks,
Long

Reply via email to