> Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build environment > and doc > > > Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build > > environment and doc > > > > On 9/3/2022 2:40 AM, lon...@linuxonhyperv.com wrote: > > > > > > > > From: Long Li <lon...@microsoft.com> > > > > > > MANA is a PCI device. It uses IB verbs to access hardware through > > > the kernel RDMA layer. This patch introduces build environment and > > > basic device probe functions. > > > > > > Signed-off-by: Long Li <lon...@microsoft.com> > > > --- > > > Change log: > > > v2: > > > Fix typos. > > > Make the driver build only on x86-64 and Linux. > > > Remove unused header files. > > > Change port definition to uint16_t or uint8_t (for IB). > > > Use getline() in place of fgets() to read and truncate a line. > > > v3: > > > Add meson build check for required functions from RDMA direct verb > > > header file > > > v4: > > > Remove extra "\n" in logging code. > > > Use "r" in place of "rb" in fopen() to read text files. > > > v7: > > > Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap. > > > > > > > Can you please check review comments on v4 [1], they seem still valid > > in this version. > > I didn't go through other patches, but can you please double check > > comments on all v4 patches? > > Sorry it was an oversight. Will remove all the "\n" and double check.
Are you referring to " Remove extra "\n" in logging code." In the comment? There are two places "\n" are used, DRV_LOG() and PMD_INIT_LOG() in mana.h. I think they are okay as there is a single "\n" on each output line. Please let me know if I missed anything. > > > > > > > [1] > > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Finbo > > x.dpdk.org%2Fdev%2F859e95d9-2483-b017-6daa- > > > 0852317b4a72%40xilinx.com%2F&data=05%7C01%7Clongli%40microsoft > > .com%7C85fe7680325e402d210408da9008036c%7C72f988bf86f141af91ab2d > 7c > > > d011db47%7C1%7C0%7C637980661342767895%7CUnknown%7CTWFpbGZsb3 > > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > %3D%7C3000%7C%7C%7C&sdata=4CHI9uw%2B0MwJtVjamECVZWvU > Yq > > BCitq7STstFNPNIN8%3D&reserved=0
