Hi,

Replies are inline.

> -----Original Message-----
> From: Morten Brørup <m...@smartsharesystems.com>
> Sent: Friday, September 16, 2022 3:36 PM
> To: Jiang, Cheng1 <cheng1.ji...@intel.com>; tho...@monjalon.net;
> Richardson, Bruce <bruce.richard...@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu...@intel.com>; Ding, Xuan
> <xuan.d...@intel.com>; Ma, WenwuX <wenwux...@intel.com>; Wang,
> YuanX <yuanx.w...@intel.com>; Yang, YvonneX
> <yvonnex.y...@intel.com>; He, Xingguang <xingguang...@intel.com>
> Subject: RE: [RFC] app/dma-perf: introduce dma-perf application
> 
> > From: Cheng Jiang [mailto:cheng1.ji...@intel.com]
> > Sent: Thursday, 15 September 2022 17.48
> >
> > There are many high-performance DMA devices supported in DPDK now,
> and
> > these DMA devices can also be integrated into other modules of DPDK as
> > accelerators, such as Vhost. Before integrating DMA into applications,
> > developers need to know the performance of these DMA devices in
> > various scenarios and the performance of CPUs in the same scenario,
> > such as different buffer lengths. Only in this way can we know the
> > target performance of the application accelerated by using them. This
> > patch introduces a high-performance testing tool, which supports
> > comparing the performance of CPU and DMA in different scenarios
> > automatically with a pre-set config file. Memory Copy performance test
> > are supported for now.
> >
> > Signed-off-by: Cheng Jiang <cheng1.ji...@intel.com>
> > Signed-off-by: Jiayu Hu <jiayu...@intel.com>
> > Signed-off-by: Yuan Wang <yuanx.w...@intel.com>
> > ---
> >  app/meson.build               |   1 +
> >  app/test-dma-perf/benchmark.c | 537
> > ++++++++++++++++++++++++++++++++++
> >  app/test-dma-perf/benchmark.h |  12 +  app/test-dma-perf/config.ini
> > |  61 ++++
> >  app/test-dma-perf/main.c      | 399 +++++++++++++++++++++++++
> >  app/test-dma-perf/main.h      |  55 ++++
> >  app/test-dma-perf/meson.build |  16 +
> >  7 files changed, 1081 insertions(+)
> >  create mode 100644 app/test-dma-perf/benchmark.c  create mode 100644
> > app/test-dma-perf/benchmark.h  create mode 100644
> > app/test-dma-perf/config.ini  create mode 100644
> > app/test-dma-perf/main.c  create mode 100644 app/test-dma-perf/main.h
> > create mode 100644 app/test-dma-perf/meson.build
> >
> 
> Excellent, thank you!

Sure, thanks!!

> 
> Is there any reason for making this a separate application, instead of part of
> the /app/test/ application?

> 
> NB: Someone could have asked the same question about test-compress-dev
> and similar applications... ;-)

First of all, this application is specifically used to test the performance of 
DMA device, and does not involve functional testing.
So I'm not sure whether it is suitable for the app/test.
Secondly, the configuration and switching of many test scenarios are involved 
here, so we think it may be a more appropriate to be an independent application.

> 
> Acked-by: Morten Brørup <m...@smartsharesystems.com>

Thanks for your acknowledgement.
Cheng

Reply via email to