On 9/13/2022 10:22 PM, Robin Jarry wrote:
CAUTION: This message has originated from an External Source. Please use proper
judgment and caution when opening attachments, clicking links, or responding to
this email.
Ferruh Yigit, Sep 13, 2022 at 22:54:
Some of the drivers doesn't provide PCI ids, but script is listing
them empty, like [1], is it better to omit the output for that case,
as done to 'params' & 'kmod'?
[snip]
[1]
{
"name": "net_enetfec",
"pci_ids": []
},
I could indeed omit the drivers that only report their name.
However, this raises another question: why do these drivers report
a PMD_INFO_STRING in the first place? Should buildtools/pmdinfogen.py be
modified as well?
I think better to display name, if there is nothing else to display,
comparing to not display anything at all.
Command can be run on the driver object, .so, so user expects to see
some output.
For above enetfec driver, it is virtual driver and doesn't support
pci_ids, and it seems doesn't have parameters or kmod requirements.
So in this case it is OK to have only name.
